Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7600
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit 196346a: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
May 18, 2023
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing this Philip, this has been a bit of a pain to manually clean that after every release (and we often forget). This is mostly a stamp but if there's any issue they'll be easy to address
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 23, 2023
Reviewed By: vmoens Differential Revision: D46071409 fbshipit-source-id: c8b296144bd7beb4036cb87c975ce94dd1c2e481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some logic in our docs that handles the version wrangling for released versions:
vision/docs/source/conf.py
Lines 96 to 105 in abc40ef
Two issues here:
VERSIONenvironment value. That is currently not the case.main(, this is retained for the final version.This PR fixes both issues. I'll send a follow-up PR to the
gh-pagesbranch to remediate this for the past two versions.